Add SetRuntimeEnvironment to all MI Driver and NI-Fake library classes #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RuntimeEnvironment-to-metadata
ni-jfitzger
commented
Jul 19, 2023
reckenro
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add SetRuntimeEnvironment to the library classes for all MI Drivers and NI-Fake
Implemented via the following changes:
source/codegen/metadata/<driver>/functions_addon.pyto privately add the SetRuntimeEnvironment function for all MI drivers and NI-Fakesource/codegen/metadata/<driver>/__init__.pyso that the new metadata will be merged. I merged metadata for attributes, functions and enums. config_addon.py had overrides that were not in use, so I did not merge them. They are most likely copy-pasta from nimi-python.Although I could include use official metadata exports, now that internal metadata is updated, that may include other changes. This way is more surgical.
Partially addresses #960
Why should this Pull Request be merged?
As developers, we want to know how much nigrpc_device_server is used and which versions.
Adding SetRuntimeEnvironment to our library classes is the first step. It's already been tested for NI-DCPower via #962
What testing has been done?
Tested NI-DCPower via #962